Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default max nginx upload size to 2GB #358

Conversation

jrussett
Copy link
Contributor

@jrussett jrussett commented Nov 21, 2023

What

In order to support new versions of the Java buildpack, and CNBs in the future, we should increase the default max upload-able file size to 2GB. See this issue:

#186470719

Checklist

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

In order to support new versions of the Java buildpack, and CNBs in the
future, we should increase the max uploadable file size to 2GB. E.g.:
- cloudfoundry/java-buildpack#1035

[#186470719](https://www.pivotaltracker.com/story/show/186470719)
@ameowlia ameowlia requested review from a-b and moleske December 4, 2023 20:34
@moleske
Copy link
Member

moleske commented Dec 4, 2023

The linked Pivotal Tracker story is private. Is there details in there that are important to know?

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my question about the linked Pivotal Tracker story, no issue for me bumping the value

@jrussett
Copy link
Contributor Author

jrussett commented Dec 6, 2023

The linked Pivotal Tracker story is private. Is there details in there that are important to know?

@moleske Not particularly. Mostly just links to discussions and that Java buildpack issue. We thought changing this on the OSS side of things would help keep everything consistent.

@moleske moleske merged commit f69b2e6 into cloudfoundry:develop Dec 8, 2023
1 check passed
@jrussett jrussett deleted the bump-default-app_bits_max_body_size-to-2GB-186470719 branch December 12, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants