This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
remove capi eirini cert config #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this allows us to remove cert configuration and stubbed defaults from capi-k8s-release default values files Authored-by: Connor Braa <[email protected]>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174778097 The labels on this github issue will be updated when the story is started. |
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
1 similar comment
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
|
Sorry for the delay here @cwlbraa; we're finally through the bulk of our recent CI issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitted to appease CI.
this allows us to remove cert configuration and bogus defaults from capi-k8s-release default values files.
WHAT is this change about?
This removes a few unnecessary properties from capi.yml that used to configure TLS communication between CAPI and eirini.
Does this PR introduce a change to
config/values.yml?No.
Acceptance Steps
It should deploy without a hitch. After this is merged, please poke us to merge cloudfoundry/capi-k8s-release#68 .