Use jq instead of grep -P for finding users to delete during integrat… #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion cleanup - was annoying me cause mac grep doesn't have -P
jdgonzaleza
approved these changes
Sep 16, 2022
moleske
commented
Sep 16, 2022
bin/cleanup-integration
Outdated
| @@ -62,8 +62,7 @@ for stack in $(cf stacks | awk '/INTEGRATION-STACK/ { print $1 }'); do | |||
| cf curl -X DELETE "/v3/stacks/$(cf stack --guid $stack)" | |||
| done | |||
|
|
|||
| CF_USERS=$(cf curl /v3/users | grep -oP '(?<="total_results":)[^"]*' |grep -o '[0-9]\+') | |||
| USER_PAGES=$(( $CF_USERS / 50 + 1)) | |||
| USER_PAGES=$(cf curl /v3/users | jq -r .pagination.total_pages) | |||
|
|
|||
| for ((i=1; i<=${USER_PAGES}; i++)) ; do | |||
| cf curl "/v3/users?per_page=50&page=${i}" | \ | |||
There was a problem hiding this comment.
I think this line needs to remove the per_page=50 part because the change above I made is just getting the total number of paginated pages for whatever the default number of users of the page is
PeteLevineA
approved these changes
Sep 20, 2022
moleske
added a commit
that referenced
this pull request
Sep 20, 2022
#2319) * Use jq instead of grep -P for finding users to delete during integration cleanup * remove per page cause we're already iterating over a known set of pages
moleske
added a commit
that referenced
this pull request
Sep 20, 2022
#2319) * Use jq instead of grep -P for finding users to delete during integration cleanup * remove per page cause we're already iterating over a known set of pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion cleanup
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Does this PR modify CLI v6, CLI v7, or CLI v8?
none it is testing related
Please see the contribution doc above or review Architecture Guide.
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
easier to understand clean up code
Why Should This Be In Core?
Explain why this functionality should be in the cf CLI, as opposed to a plugin.
it's integration test cleanup related
Applicable Issues
List any applicable Github Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
🤷
Other Relevant Parties
Who else is affected by the change?