Explicity enable route_sharing feature on tests that need it

[moleske]

• previously tests were not stating they needed this feature enable, only a minimum version of capi
• since the feature is not enabled by default, this adds a call to enable it
• attempt to disable it after each test, however when tests run in parallel, this caused the tests to fight each other on turning it on and off. Since a minimum capi version is checked and we don't have tests that explicitly test the feature being disabled, it seems ok to just leave it on

I checked the "allow edits and access to secrets by maintainers, so any approver should be able to push commits if they see small issues

Thank you for contributing to the CF CLI! Please read the following:

• Please make sure you have implemented changes in line with the contributing guidelines
• We're not allowed to accept any PRs without a signed CLA, no matter how small.
  If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
• All new code requires tests to protect against regressions.
• Contributions must be made against the appropriate branch. See the contributing guidelines
• Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?

Modifies tests to make github actions integration test work better, so should be backported to all versions still under testing

Please see the contribution doc above or review Architecture Guide.

Description of the Change

Explicitly enable route_sharing feature on tests that need it

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

Will allow folks to just run the tests instead of configuring their cloud foundry install

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Why Should This Be In Core?

n/a

Explain why this functionality should be in the cf CLI, as opposed to a plugin.

Applicable Issues

List any applicable Github Issues here
#2326

How Urgent Is The Change?

As urgent as we want integration tests to work on github actions

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

@cloudfoundry/wg-app-runtime-interfaces-cli-approvers
@cloudfoundry/wg-app-runtime-interfaces-cli-reviewers

Who else is affected by the change?

[jdgonzaleza]

I'm curious... didn't we have something for this in the integration tests setup? weren't we enabling some feature flags?

[moleske]

I'm curious... didn't we have something for this in the integration tests setup? weren't we enabling some feature flags?

The last commit here moves the enabling to a helper file which is also enabling the flags "diego_docker" and "service_instance_sharing" so adding "route_sharing" there seems to be consistent with what we've got

[jdgonzaleza]

I'm curious... didn't we have something for this in the integration tests setup? weren't we enabling some feature flags?

The last commit here moves the enabling to a helper file which is also enabling the flags "diego_docker" and "service_instance_sharing" so adding "route_sharing" there seems to be consistent with what we've got

ohhhh Sorry!!! I didn't see which file was being modified!

[moleske]

One concern I thought of is "route_sharing" is not available on all versions of capi. So trying to enable this feature on a version of capi where "route_sharing" does not exist could fail badly. The original location in each test had a check on the version of capi so it was only being enable on a version of capi that support "route_sharing"