Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubuntu 18.04 and macos-10.15 from unit tests #2416

Closed
wants to merge 1 commit into from
Closed

Remove ubuntu 18.04 and macos-10.15 from unit tests #2416

wants to merge 1 commit into from

Conversation

moleske
Copy link
Member

@moleske moleske commented May 5, 2023

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?

it's pipeline stuff

Please see the contribution doc above or review Architecture Guide.

Description of the Change

remove environments that don't exist

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

cause I won't be confused when the checks seem to be pending forever for environments that don't exist

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Why Should This Be In Core?

cause it is pipeline stuff

Explain why this functionality should be in the cf CLI, as opposed to a plugin.

Applicable Issues

no

List any applicable GitHub Issues here

How Urgent Is The Change?

I mean someday it'd be nice

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

anyone who makes prs

Who else is affected by the change?

@moleske
Copy link
Member Author

moleske commented May 17, 2023

looks like was resolved in #2422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants