-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CVE scan GitHub workflow that is triggered on pull requests #2977
Merged
a-b
merged 2 commits into
cloudfoundry:main
from
weresch:187767453-add-cve-scanner-gha-workflow
Jun 28, 2024
Merged
Add CVE scan GitHub workflow that is triggered on pull requests #2977
a-b
merged 2 commits into
cloudfoundry:main
from
weresch:187767453-add-cve-scanner-gha-workflow
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- run on each commit, PR, and on-demand
I paired on this work with @chinigo |
a-b
reviewed
Jun 27, 2024
Considering the volume of shell scripts we're writing, should we try https://github.com/shellspec/shellspec ? |
a-b
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
weresch
added a commit
to weresch/cli
that referenced
this pull request
Jun 28, 2024
…dfoundry#2977) * Add a GitHub workflow to scan for CVEs * Run on each commit, PR, and on-demand * Remove CVE scan workflow trigger on commits
weresch
added a commit
to weresch/cli
that referenced
this pull request
Jun 28, 2024
…dfoundry#2977) * Add a GitHub workflow to scan for CVEs * Run on each commit, PR, and on-demand * Remove CVE scan workflow trigger on commits
This was referenced Jun 28, 2024
a-b
pushed a commit
that referenced
this pull request
Jul 1, 2024
… (#2978) * Add a GitHub workflow to scan for CVEs * Run on each commit, PR, and on-demand * Remove CVE scan workflow trigger on commits
a-b
pushed a commit
that referenced
this pull request
Jul 1, 2024
… (#2979) * Add a GitHub workflow to scan for CVEs * Run on each commit, PR, and on-demand * Remove CVE scan workflow trigger on commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Note: Please create separate PR for every branch (main, v8 and v7) as needed.
Description of the Change
Adding a CVE scan GitHub workflow on PRs.
Why Is This PR Valuable?
The CVE scan GitHub workflow on PRs helps prevent known CVEs from being added to the codebase.
Applicable Issues
No applicable issues
How Urgent Is The Change?
Not urgent
Other Relevant Parties
No one else