Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest CAPI #3028

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Use latest CAPI #3028

merged 2 commits into from
Jul 16, 2024

Conversation

gururajsh
Copy link
Member

Use the latest version of CAPI to run integration tests.

@gururajsh gururajsh requested a review from joaopapereira July 15, 2024 20:43
@@ -19,7 +19,7 @@ var _ = Describe("curl command", func() {
It("returns the expected request with verbose output", func() {
session := helpers.CF("curl", "-v", "/v2/banana")
Eventually(session).Should(Say("GET /v2/banana HTTP/1.1"))
Eventually(session).Should(Say(`"error_code": "CF-NotFound"`))
Eventually(session).Should(Say(`"error_code":"CF-NotFound"`))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/non-blocking Perhaps just searching for the string CF-NotFound would be more robust.

Copy link
Contributor

@Samze Samze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit df3d91c into cloudfoundry:v7 Jul 16, 2024
15 checks passed
@gururajsh gururajsh deleted the latest-capi branch July 16, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants