Canary Deployment Changes #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samze
reviewed
Jul 31, 2024
Samze
reviewed
Jul 31, 2024
| h.Name = constant.DeploymentStrategy(valLower) | ||
|
|
||
| default: | ||
| return &flags.Error{ | ||
| Type: flags.ErrInvalidChoice, | ||
| Message: `STRATEGY must be "rolling" or not set`, | ||
| Message: `STRATEGY must be "canary", "rolling" or not set`, |
There was a problem hiding this comment.
non-blocking/thought I'd favour letting the API decide what is a valid strategy rather than enumerating it in the CLI.
Samze
reviewed
Jul 31, 2024
Samze
reviewed
Jul 31, 2024
Samze
reviewed
Jul 31, 2024
- Changes to CC api to send in the deployment strategy (before CLI didn't send one and it was assumed to be rolling) - Restart command support for canary Co-authored-by: Joao Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Co-authored-by: Sam Gunaratne <[email protected]>
Co-authored-by: Sam Gunaratne <[email protected]>
gururajsh
force-pushed
the
canary-restart-command-v8
branch
from
b66d405 to
24717d9
Compare
Samze
previously approved these changes
Aug 6, 2024
Signed-off-by: João Pereira <[email protected]>
Samze
approved these changes
Aug 6, 2024
gururajsh
added a commit
to gururajsh/cli
that referenced
this pull request
Aug 7, 2024
Introduce canary strategy on all the commands Co-authored-by: João Pereira <[email protected]>
joaopapereira
added a commit
to joaopapereira/cf-cli
that referenced
this pull request
Aug 7, 2024
Introduce canary strategy on all the commands Co-authored-by: João Pereira <[email protected]>
gururajsh
added a commit
to gururajsh/cli
that referenced
this pull request
Aug 7, 2024
Introduce canary strategy on all the commands Co-authored-by: João Pereira <[email protected]>
joaopapereira
added a commit
that referenced
this pull request
Aug 7, 2024
Introduce canary strategy on all the commands Co-authored-by: João Pereira <[email protected]>
nicolasbender
pushed a commit
to sap-contributions/cli
that referenced
this pull request
Nov 5, 2024
Introduce canary strategy on all the commands Co-authored-by: João Pereira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Joao Pereira
[email protected]