-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cf revisions
no longer reports EXPERIMENTAL notice [v8]
#3061
cf revisions
no longer reports EXPERIMENTAL notice [v8]
#3061
Conversation
cf revisions
no longer reports EXPERIMENTAL noticecf revisions
no longer reports EXPERIMENTAL notice [v7]
cf revisions
no longer reports EXPERIMENTAL notice [v7]cf revisions
no longer reports EXPERIMENTAL notice [v8]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a1f7feb
to
411b7b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the test was there to ensure that the message was present I do not think these tests make sense anymore.
If you come back to the code and see this test, it is strange 😄
While tests as they are right now could document the promotion of the command from experimental to the core. I +1 to @joaopapereira 's point - It's better to remove these tests at all. |
411b7b2
to
a9c07fb
Compare
|
a9c07fb
to
0b82390
Compare
Updated PR to incorporate @Samze's feedback on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the Change
This commit changes the
cf revision
andcf revisions
commands to no longer print a notice that the command is experimental.Why Is This PR Valuable?
The
cf revision
andcf revisions
commands were introduced over 4 years ago and are no longer experimental.Applicable Issues
n/a
How Urgent Is The Change?
Not urgent.
Other Relevant Parties
None
Related PRs
cf revisions
no longer reports EXPERIMENTAL notice [v7] #3060 - v7cf revisions
no longer reports EXPERIMENTAL notice [v8] #3061 - v8 (this PR)cf revisions
no longer reports EXPERIMENTAL notice [main] #3062 - main