Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error reporting with feeded curl data is not enclosed. #588

Merged
merged 1 commit into from
Sep 28, 2015

Conversation

Zouuup
Copy link
Contributor

@Zouuup Zouuup commented Sep 17, 2015

this will also help with this issue on PivotalTracker:
https://www.pivotaltracker.com/n/projects/892938/stories/95206110

@cfdreddbot
Copy link

Hey Zouuup!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/103610878.

@Zouuup
Copy link
Contributor Author

Zouuup commented Sep 17, 2015

emm, i think there was a problem with cfdreddbot, my newer PR #590 has CLA passed, do i need to resend PR?

@Zouuup
Copy link
Contributor Author

Zouuup commented Sep 17, 2015

there is a problem with corporate licence, i'll take care of that.

@camelpunch
Copy link
Contributor

Your username is on the bot's whitelist, not sure why it didn't pick it up.

@camelpunch
Copy link
Contributor

Minor: can we lower-case Argument in that error sentence please? Also, squashing the commits so we don't have undos in the history would be nice.

@Zouuup
Copy link
Contributor Author

Zouuup commented Sep 25, 2015

Done sir ;)

camelpunch added a commit that referenced this pull request Sep 28, 2015
better error reporting with feeded curl data is not enclosed.
@camelpunch camelpunch merged commit 4d5fe31 into cloudfoundry:master Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants