Make sure tests are independent of real execution time

Co-authored-by: Aftab Alam <[email protected]>

spec/unit/jobs/reoccurring_job_spec.rb

@@ -75,10 +75,13 @@ def perform
         job.polling_interval_seconds = 95
         expect(job.polling_interval_seconds).to eq(95)
 
-        enqueued_time = Time.now
+        enqueued_time = 0
 
-        Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
-        execute_all_jobs(expected_successes: 1, expected_failures: 0)
+        Timecop.freeze do
+          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          enqueued_time = Time.now
+        end
 
         Timecop.freeze(94.seconds.after(enqueued_time)) do
           execute_all_jobs(expected_successes: 0, expected_failures: 0)
@@ -103,10 +106,13 @@ def perform
           it 'when changing exponential backoff rate only' do
             TestConfig.config[:broker_client_async_poll_exponential_backoff_rate] = 2.0
 
-            enqueued_time = Time.now
+            enqueued_time = 0
 
-            Jobs::Enqueuer.new(FakeJob.new, queue: Jobs::Queues.generic).enqueue_pollable
-            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+            Timecop.freeze do
+              Jobs::Enqueuer.new(FakeJob.new, queue: Jobs::Queues.generic).enqueue_pollable
+              execute_all_jobs(expected_successes: 1, expected_failures: 0)
+              enqueued_time = Time.now
+            end
 
             [60, 180, 420, 900, 1860].each do |seconds|
               Timecop.freeze((seconds - 1).seconds.after(enqueued_time)) do
@@ -122,10 +128,13 @@ def perform
             TestConfig.config[:broker_client_async_poll_exponential_backoff_rate] = 1.3
             TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-            enqueued_time = Time.now
+            enqueued_time = 0
 
-            Jobs::Enqueuer.new(FakeJob.new, queue: Jobs::Queues.generic).enqueue_pollable
-            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+            Timecop.freeze do
+              Jobs::Enqueuer.new(FakeJob.new, queue: Jobs::Queues.generic).enqueue_pollable
+              execute_all_jobs(expected_successes: 1, expected_failures: 0)
+              enqueued_time = Time.now
+            end
 
             [10, 23, 39.9, 61.8, 90.4].each do |seconds|
               Timecop.freeze((seconds - 1).seconds.after(enqueued_time)) do
@@ -138,14 +147,16 @@ def perform
             end
           end
           it 'when changing exponential backoff rate and retry_after from the job' do
-            job = FakeJob.new(retry_after: [20, 30])
             TestConfig.config[:broker_client_async_poll_exponential_backoff_rate] = 1.3
             TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-            enqueued_time = Time.now
+            enqueued_time = 0
 
-            Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
-            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+            Timecop.freeze do
+              Jobs::Enqueuer.new(FakeJob.new(retry_after: [20, 30]), queue: Jobs::Queues.generic).enqueue_pollable
+              execute_all_jobs(expected_successes: 1, expected_failures: 0)
+              enqueued_time = Time.now
+            end
 
             # the job should run after 20s * 1.3^0 = 20 seconds
             Timecop.freeze(19.seconds.after(enqueued_time)) do
@@ -176,8 +187,12 @@ def perform
           # With a backoff rate of 1.3, 11 jobs could have been executed in 60 minutes (initial run + 10 retries).
           job.instance_variable_set(:@retry_number, 10)
 
-          enqueued_time = Time.now
-          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+          enqueued_time = 0
+
+          Timecop.freeze do
+            Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
+            enqueued_time = Time.now
+          end
 
           # The calculated backoff for the 11th retry would be 3384.321 seconds.
           Timecop.freeze(enqueued_time + 3384.321.ceil.seconds) do
@@ -194,13 +209,15 @@ def perform
 
       context 'updates the polling interval if config changes' do
         it 'when changed from the job only' do
-          job = FakeJob.new(retry_after: [20, 30])
           TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-          enqueued_time = Time.now
+          enqueued_time = 0
 
-          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
-          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          Timecop.freeze do
+            Jobs::Enqueuer.new(FakeJob.new(retry_after: [20, 30]), queue: Jobs::Queues.generic).enqueue_pollable
+            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+            enqueued_time = Time.now
+          end
 
           Timecop.freeze(19.seconds.after(enqueued_time)) do
             execute_all_jobs(expected_successes: 0, expected_failures: 0)
@@ -221,13 +238,15 @@ def perform
         end
 
         it 'when default changed after changing from the job' do
-          job = FakeJob.new(retry_after: [20])
           TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-          enqueued_time = Time.now
+          enqueued_time = 0
 
-          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
-          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          Timecop.freeze do
+            Jobs::Enqueuer.new(FakeJob.new(retry_after: [20]), queue: Jobs::Queues.generic).enqueue_pollable
+            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+            enqueued_time = Time.now
+          end
 
           Timecop.freeze(19.seconds.after(enqueued_time)) do
             execute_all_jobs(expected_successes: 0, expected_failures: 0)
@@ -249,13 +268,15 @@ def perform
         end
 
         it 'when changing default only' do
-          job = FakeJob.new
           TestConfig.config[:broker_client_default_async_poll_interval_seconds] = 10
 
-          enqueued_time = Time.now
+          enqueued_time = 0
 
-          Jobs::Enqueuer.new(job, queue: Jobs::Queues.generic).enqueue_pollable
-          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+          Timecop.freeze do
+            Jobs::Enqueuer.new(FakeJob.new, queue: Jobs::Queues.generic).enqueue_pollable
+            execute_all_jobs(expected_successes: 1, expected_failures: 0)
+            enqueued_time = Time.now
+          end
 
           Timecop.freeze(9.seconds.after(enqueued_time)) do
             execute_all_jobs(expected_successes: 0, expected_failures: 0)