Adapt presenter_args function for /v3/security_groups and /v3/space_quotas as in /v3/domains #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
add-consistency-to-last-changes
branch
from
e723dc7 to
ee640cd
Compare
kathap
changed the title
kathap
force-pushed
the
add-consistency-to-last-changes
branch
from
ee640cd to
c09ee61
Compare
* add consistency and use in the former changed /v3/space_quotas and /v3/security-groups files the same presenter_args function as for the /v3/domains changement * adjust :all in space_quota_apply and security_group_apply * adjust controllers for space_quotas and security_groups * adjust tests for space_quota_apply and security_group_apply
kathap
force-pushed
the
add-consistency-to-last-changes
branch
from
c09ee61 to
eca20c0
Compare
philippthun
approved these changes
Feb 2, 2022
|
This addresses @sethboyles' comment and applies the same to something we've previously added. |
sethboyles
approved these changes
Feb 2, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v3/security-groups (Reduce db calls in /v3/security_groups and /v3/space_quotas/ #2624) files the same presenter_args function as for the
/v3/domains changement (Reduce db calls in /v3/domains #2638) so that instead of selecting all space guids for admin user, all_spaces_visible is set to true and if so no filtering is done, just return all space guids
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests