Implement exponential backoff for service fetch operations (CC API v2) #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the tests we would be glad about feedback, as they are quite different from the v3 tests. The tests can be replicated to the service binding test file after we found some good ones. Tests are failing because this PR depends on #2667 |
svkrieger
force-pushed
the
implement-exponential-backoff-for-sb-operations-v2
branch
from
c137330 to
9749856
Compare
philippthun
reviewed
Feb 16, 2022
svkrieger
force-pushed
the
implement-exponential-backoff-for-sb-operations-v2
branch
from
9749856 to
fa6daa7
Compare
iaftab-alam
force-pushed
the
implement-exponential-backoff-for-sb-operations-v2
branch
from
fa6daa7 to
27cc0d5
Compare
Co-authored-by: Aftab Alam <[email protected]>
svkrieger
force-pushed
the
implement-exponential-backoff-for-sb-operations-v2
branch
from
27cc0d5 to
66f8016
Compare
philippthun
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
This PR introduces a exponential backoff for service fetch operations in CC API v2, just like in Implement exponential backoff for SB operations (CC v3 API) #2667
This PR depends on the above one.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests