Return correct docker port #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a rollback (e.g. canceled deployment) a wrong process/droplet state was used resulting in the default port (8080) being returned. With this change the port information from the desired droplet is used if it is staged.
5 tasks
This test fails without the previous commit e1b36bd.
sethboyles
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #2976 the correct docker port from the desired droplet is only returned if the process does not need staging.
I've found the story "API should support docker apps not listening on port 8080" in PivotalTracker [1] and the corresponding commit in ccng [2]. The commit message contains a table which I'm repeating here in a simplified form:
According to this table the custom port from the Dockerfile (i.e. execution metadata) should only be returned if the docker app is staged. This PR changes the condition from "the process does not need staging" to "the desired droplet is staged" and thus prevents the wrong package state calculation for aborted deployments outlined in #2975.
Closes #2976
[1] https://www.pivotaltracker.com/n/projects/2196383/stories/167149569
[2] e1a87d7
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests