Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip superseded deployments with no running instances #3084

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Nov 30, 2022

When a deployment train is canceled, the latest interim web process is scaled up. To not end up with a broken app, superseded deployments with a web process having no running instances are skipped.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

When a deployment train is canceled, the latest interim web process is
scaled up. To not end up with a broken app, superseded deployments with
a web process having no running instances are skipped.
@philippthun philippthun force-pushed the skip-superseded-deployments-with-no-running-instances branch from d276f64 to 53f4594 Compare January 16, 2023 14:36
@philippthun philippthun marked this pull request as ready for review January 16, 2023 15:42
@sethboyles
Copy link
Member

LGTM

Side note: IMO trains are a confusing and hidden aspect of deployments. I don't think we even have documentation on how trains (are intended) to work and their use case? Maybe it's worth adding some.

@philippthun philippthun merged commit 5614bf7 into cloudfoundry:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants