Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loggregator: add flag to deprecate v4 bindings endpoint #3100

Conversation

fhambrec
Copy link
Contributor

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    The PR adds a flag to allow the syslog-binding-cache to check if the new v5 endpoint is already available

  • An explanation of the use cases your change solves
    The change solves the issue of using a fallback from v5 to v4 endpoints during the next update while ensuring a fallback does not happen in case of a malfunctioning cloud controller.

  • Links to any other associated PRs
    Adding support for syslog+mtls drains in the syslog-agent loggregator-agent-release#119

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@philippthun philippthun merged commit ec85582 into cloudfoundry:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants