Use space subqueries for fetchting service credential bindings #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johha
force-pushed
the
space-subquery-for-service-binding
branch
from
b3ee59a to
e46c6af
Compare
As a regular user the select query for service credential bindings is filtered by a list of space guids (spaces the user has access to). This can produce very long queries. Instead we can use subqueries to filter the spaces directly on the db. The same approach is used in the list services endpoint, see cloudfoundry#2580.
johha
force-pushed
the
space-subquery-for-service-binding
branch
from
e46c6af to
ecbc749
Compare
philippthun
reviewed
Dec 19, 2022
philippthun
reviewed
Dec 20, 2022
johha
force-pushed
the
space-subquery-for-service-binding
branch
from
d0229e4 to
8a28d92
Compare
philippthun
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a regular user the select query for service credential bindings is filtered by a list of space guids (spaces the user has access to).
This can produce very long db queries. Instead we can use subqueries to filter the spaces directly in the db. The same approach is used in service lists, see #2580.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests