Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override empty_from_sql for MySQL #3121

Merged

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Dec 21, 2022

Specify a dummy table name for situations where no table is referenced. See MySQL 5.7 Reference Manual [1] and suggested workaround [2].

[1] https://dev.mysql.com/doc/refman/5.7/en/select.html
[2] jeremyevans/sequel#1977 (comment)

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

Specify a dummy table name for situations where no table is referenced.
See MySQL 5.7 Reference Manual [1] and suggested workaround [2].

[1] https://dev.mysql.com/doc/refman/5.7/en/select.html
[2] jeremyevans/sequel#1977 (comment)
@philippthun philippthun marked this pull request as ready for review December 21, 2022 19:27
Copy link
Contributor

@johha johha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@philippthun philippthun merged commit 6eab203 into cloudfoundry:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants