Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubernetes #3140

Merged
merged 10 commits into from
Jul 19, 2023
Merged

Remove kubernetes #3140

merged 10 commits into from
Jul 19, 2023

Conversation

moleske
Copy link
Member

@moleske moleske commented Jan 14, 2023

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    Since capi-k8s-release and cf-for-k8s are both deprecated and not supported because of korfi, it seemed like a reasonable thing to remove kubernetes related code to reduce complexity (maybe)

I didn't touch any models cause that involved more thought than I wanted to do for this experiment. This all is like big breaking changes anyway.

This was not done with the idea "we should quickly go remove k8s things" but more of a "I wonder if we could"

  • An explanation of the use cases your change solves
    So I don't have to think about kpack or other things when working cloud controller in a bosh/vms world

  • Links to any other associated PRs
    capi-release pr

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

passing run of CATS version 12.1.0 on a bosh lite with the following config

{
  "admin_user": "admin",
  "skip_ssl_validation": true,
  "use_http": true,
  "include_apps": true,
  "include_capi_experimental": true,
  "include_detect": true,
  "include_security_groups": true,
  "include_services": true,
  "include_v3": true,
  "include_tasks": true,
  "include_backend_compatibility": false,
  "include_capi_no_bridge": false,
  "include_container_networking": false,
  "include_credhub" : false,
  "include_docker": false,
  "include_internet_dependent": false,
  "include_isolation_segments": false,
  "include_persistent_app": false,
  "include_private_docker_registry": false,
  "include_privileged_container_support": false,
  "include_route_services": false,
  "include_routing": false,
  "include_routing_isolation_segments": false,
  "include_service_discovery": false,
  "include_service_instance_sharing": false,
  "include_ssh": false,
  "include_sso": false,
  "include_zipkin": false
}
older run of CATS version 9.5.0 with the following config ```json { "skip_ssl_validation": true, "use_http": true, "include_apps": true, "include_capi_experimental": true, "include_detect": true, "include_security_groups": true, "include_services": true, "include_v3": true, "include_tasks": true, "include_backend_compatibility": false, "include_capi_no_bridge": false, "include_container_networking": false, "include_credhub" : false, "include_docker": false, "include_internet_dependent": false, "include_isolation_segments": false, "include_persistent_app": false, "include_private_docker_registry": false, "include_privileged_container_support": false, "include_route_services": false, "include_routing": false, "include_routing_isolation_segments": false, "include_service_discovery": false, "include_service_instance_sharing": false, "include_ssh": false, "include_sso": false, "include_zipkin": false } ``` and had the following failure on a bosh-lite but I didn't retry cause my day ended ```bash Summarizing 1 Failure: [FAIL] [services] Service Instance Lifecycle Synchronous operations when there is an app [BeforeEach] bindings can bind service to app and send arbitrary params /home/pivotal/workspace/cf-acceptance-tests/services/service_instance_lifecycle.go:545

Ran 125 of 233 Specs in 3171.070 seconds
FAIL! -- 124 Passed | 1 Failed | 2 Pending | 106 Skipped

</details>

@moleske moleske force-pushed the remove-kubernetes branch from 5446f92 to e32c810 Compare March 24, 2023 21:01
@moleske moleske force-pushed the remove-kubernetes branch 2 times, most recently from 236796e to 4122e6c Compare April 14, 2023 21:17
@moleske moleske marked this pull request as ready for review April 14, 2023 21:46
@moleske
Copy link
Member Author

moleske commented Apr 14, 2023

I'm marking this ready as cats is passing on a bosh lite. I'm not particularly positive we should merge as is or if there's a smaller way to do this. I'd love thoughts on breaking change concerns for thise

def has_docker_image?
docker? || kpack?
docker?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method can probably go away or become an alias.

@tcdowney
Copy link
Member

@braunsonm y'all aren't using this right?

@braunsonm
Copy link

Yea @tcdowney but our version is fairly out of date at this point. We've known this wasn't being maintained for awhile now so understandable that it's getting removed.

So long as you aren't planning on removing the old release images or anything we should be fine.

Appreciate the call out.

@sethboyles
Copy link
Member

@tcdowney this also removes OPI/Eirini code--do you know the status of that project?

@tcdowney
Copy link
Member

@tcdowney this also removes OPI/Eirini code--do you know the status of that project?

It's no longer under active development, but may still be under some light maintenance? Development work was shifted over time from eirini -> eirini-controller -> korifi. @gcapizzi is one of the WG leads for it so he might be able to answer better.

@moleske moleske force-pushed the remove-kubernetes branch from 6c4b917 to 533c57f Compare April 28, 2023 23:31
@gcapizzi
Copy link
Contributor

gcapizzi commented May 4, 2023

Eirini is only used in cf-for-k8s, which I think has been deprecated and archived, so I think it's safe to get rid of the Eirini stuff from CC.

@moleske moleske force-pushed the remove-kubernetes branch from 533c57f to 25595c9 Compare May 5, 2023 23:44
@mkocher
Copy link
Member

mkocher commented May 9, 2023

Nice, I've come across this code when making changes to cloud controller. Thanks for cleaning it up!

@moleske moleske force-pushed the remove-kubernetes branch from 25595c9 to 68e6860 Compare May 26, 2023 17:52
@moleske moleske force-pushed the remove-kubernetes branch from 68e6860 to d5e6326 Compare June 30, 2023 23:31
@sethboyles
Copy link
Member

@moleske I say let's merge this!

Copy link
Member

@tcdowney tcdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye Kubernetes 🥲

@moleske moleske merged commit 640009b into main Jul 19, 2023
@moleske moleske deleted the remove-kubernetes branch July 19, 2023 17:52
moleske added a commit to cloudfoundry/capi-ci that referenced this pull request Nov 3, 2023
moleske added a commit to cloudfoundry/capi-ci that referenced this pull request Nov 6, 2023
* Remove references and leftovers of k8s pipeline resources

- k8s was removed in cloud_controller_ng cloudfoundry/cloud_controller_ng#3140

* Remove unused pack dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants