Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby-debug-ide and debase #3175

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Remove ruby-debug-ide and debase #3175

merged 1 commit into from
Feb 8, 2023

Conversation

sethboyles
Copy link
Member

This PR removes ruby-debug-ide. We face an issue where, when bundling for the first time on a new env, the first attempt at installing ruby-debug-ide fails and bundling a second time magically works.

We're opening this PR because we aren't sure anyone is using it--we think IDEs like RubyMine should work fine without this gem. As far as we can gather, we think this was added to debug running instances of CCNG. We think breakpoints in tests run from RubyMine should work.

Alternatively we can add this to a separate gem group (e.g. ide) and exclude that when installing if others are using this.

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval assuming we don't get feedback saying lots of folks use this gem

@johha
Copy link
Contributor

johha commented Feb 7, 2023

I also had issues with ruby-debug-ide in IntelliJ which I could fix by removing it from the Gemfile locally.
There are multiple debug gems which are optimized for different IDEs so it make sense to remove it from the the Gemfile.
Example: @will-gant used debug with VSCode and it worked fine but caused some issues with IntelliJ/RubyMine.

@sethboyles sethboyles merged commit 3f610e8 into main Feb 8, 2023
@moleske moleske deleted the remove-ruby-debug-ide branch February 8, 2023 03:57
@moleske moleske mentioned this pull request Jul 7, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants