Add helper script to benchmark rate limiting #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
benchmark-rate-limiting-script
branch
from
611396d to
01f1e15
Compare
This script needs to be piped into bin/console on the api vm.
philippthun
force-pushed
the
benchmark-rate-limiting-script
branch
from
01f1e15 to
491e9d0
Compare
3 tasks
moleske
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Didn't test it myself, but seems ok. Is there a use for this script outside of manual testing?
edit - Oh I missed the link to capi-release pr, this makes more sense in that context. capi-release has a scripts directory, does it make more sense for it to live there?
I will leave it here as there are similar helper scripts in this location. Still not the perfect location; maybe someone will clean this up at some point in time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script needs to be piped into bin/console on the api vm.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests