Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose process version on the v3 API #3327

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Expose process version on the v3 API #3327

merged 1 commit into from
Jun 29, 2023

Conversation

Gerg
Copy link
Member

@Gerg Gerg commented Jun 28, 2023

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

Expose process versions on the v3 API.

  • An explanation of the use cases your change solves

Process versions were already exposed on the v2 API in various places (e.g. GET /v2/apps. We did not bring this field over to v3.

I've historically been opposed to exposing process versions in v3, because they feel like an internal implementation detail of how CC and Diego stay in sync with eachother. That said, process versions are occasionally useful when locating LRPs in diego or debugging issues with the CAPI sync job. I've found myself using the v2 API to get process versions, which has demonstrated the value of bringing this forward to the v3 API.

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@philippthun philippthun merged commit f34bff8 into main Jun 29, 2023
@moleske moleske deleted the v3_process_version branch June 29, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants