Eager load domains for routes associated with a process #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'routes' association in the 'process' model is used to determine the 'uris' belonging to a process. This also requires the 'name' from the associated 'domain' which leads to 1 + n SELECT queries (1 * SELECT FROM routes + n * SELECT FROM domains), where n is the number of associated routes. When eager loading domains, there are only 2 SELECT queries no matter how many routes are associated with a process.
|
Thanks for finding this, @chombium! |
|
Thank you too for fixing the problem that soon @philippthun ;) |
tcdowney
approved these changes
Aug 15, 2023
|
@philippthun @moleske do y'all think this is good to merge? |
moleske
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
routesassociation in theprocessmodel is used to determine theurisbelonging to a process. This also requires thenamefrom the associateddomainwhich leads to 1 + nSELECTqueries (1 *SELECT FROM routes+ n *SELECT FROM domains), where n is the number of associated routes. When eager loading domains, there are only 2SELECTqueries no matter how many routes are associated with a process.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests