Display instance internal IP address on Process Stats endpoint #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows users to see the internal container IP address for a process
tcdowney
force-pushed
the
add-internal-ip-process-stats
branch
from
31cc815 to
85430e5
Compare
Authored-by: Tim Downey <[email protected]>
tcdowney
changed the title
moleske
approved these changes
Sep 26, 2023
geofffranks
added a commit
to geofffranks/cloud_controller_ng
that referenced
this pull request
Oct 19, 2023
…foundry#3378) * Add instance_internal_ip field to ProcessStats endpoint - Allows users to see the internal container IP address for a process * Add docs for instance_internal_ip field Authored-by: Tim Downey <[email protected]> Co-authored-by: Geoff Franks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with adding the internal IP address (as the
instance_internal_ipfield) to the process stats endpoint for #1378. This matches theCF_INSTANCE_INTERNAL_IP=10.255.93.167env var and I'm open to other names for sure. Maybe justinternal_ip?Example:
{ "resources": [ { "type": "web", "index": 0, "state": "RUNNING", "host": "10.244.0.139", "instance_internal_ip": "10.255.93.167", "uptime": 1524, "mem_quota": 268435456, "disk_quota": 1073741824, "log_rate_limit": -1, "fds_quota": 16384, "isolation_segment": null, "details": null, "instance_ports": [ { "external": 61000, "internal": 8080, "external_tls_proxy_port": 61002, "internal_tls_proxy_port": 61001 }, { "external": 61000, "internal": 8080, "external_tls_proxy_port": null, "internal_tls_proxy_port": 61443 }, { "external": 61001, "internal": 2222, "external_tls_proxy_port": 61003, "internal_tls_proxy_port": 61002 } ], "usage": { "time": "2023-08-07T22:39:50+00:00", "cpu": 0.003555510033188645, "mem": 59051576, "disk": 175616000, "log_rate": 0 } } ] }I think there are probably some request specs that I didn't account for, but if this is a change we actually want I'm happy to fix those up as well.