Don't show service route binding parameters not in state create succeeded #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state create initial or create failed For GET /v3/service_route_bindings/:guid/parameters, if the state is create initial or create failed, it should not return parameters. It should raise an error when GET /v3/service_route_bindings/:guid/parameters, is called instead of showing empty data.
philippthun
changed the title
philippthun
reviewed
Sep 29, 2023
5 tasks
|
@kathap - Changes look good! Could you please squash your commits, then I will approve and merge the PR. |
moleske
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
looks good and since @philippthun also said it looks good I'm just using github's squash and merge to get the changes in one commit
5 tasks
geofffranks
pushed a commit
to geofffranks/cloud_controller_ng
that referenced
this pull request
Oct 19, 2023
…eded (cloudfoundry#3443) * Throw error for GET /v3/service_route_bindings/:guid/parameters with state create initial or create failed For GET /v3/service_route_bindings/:guid/parameters, if the state is create initial or create failed, it should not return parameters. It should raise an error when GET /v3/service_route_bindings/:guid/parameters, is called instead of showing empty data. Co-authored-by: Josh Russett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix as part of #2637. It contains changes in behaviour for:
For GET /v3/service_route_bindings/:guid/parameters, if the state is not create succeeded, it should not return parameters. It should raise an error when GET /v3/service_route_bindings/:guid/parameters is called instead of showing empty data.
Links to any other associated PRs
Treat failed service-credential-binding and service-credential-key as non-existent / Do not cleanup failed bindings in apply_manifest #2636
Dont show service credential keys not in state create succeeded #2679
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests