Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded psych gem #3486

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

moleske
Copy link
Member

@moleske moleske commented Oct 20, 2023

We could keep psych in the gemfile if we feel value in staying on the latest version psych instead of what version of psych ruby provides. I don't have strong feelings either way (well strong enough to make a pr, not strong enough to advocate deeply)

The key thing we needed to resolve the issue was strict_integer: true in all the parse commands, nothing else from psych we cared all that much about

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

- in #2807 we manually set psych so we could resolve #2193
- the newer psych is available as a default gem in [ruby 3.2](https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/)
Copy link
Member

@philippthun philippthun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also favor removing this, as long as we don't need a specific (newer) version.

@philippthun philippthun merged commit 7a77042 into main Oct 23, 2023
@moleske moleske deleted the remove-unneeded-explicit-psych-gem branch October 23, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numbers with commas in space manifests get parsed as an integer, not a string
2 participants