Implement additional audit events #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johha
force-pushed
the
audit_events
branch
2 times, most recently
from
8299713 to
1e45a00
Compare
Some API endpoints which return credentials do not write audit events. This change adds the following audit events: - `audit.service_instance.show` & `audit.user_provided_service_instance.show` Endpoints: - GET /v2/service_instances/:guid - GET /v3/service_instances/:guid/credentials - `audit.service_binding.show` Endpoints: - GET /v3/service_credential_bindings/:guid/details - GET /v2/service_bindings/:guid - `audit.service_key.show` Endpoints: - GET /v3/service_credential_bindings/:guid/details - GET /v2/service_keys/:guid Co-authored-by: Wei Quan <[email protected]>
moleske
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
@MerricdeLauney and I took a look and this looks good to us!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some API endpoints which return credentials do not write audit events. This change adds the following audit events:
audit.service_instance.show&audit.user_provided_service_instance.showEndpoints:
audit.service_binding.showEndpoints:
audit.service_key.showEndpoints:
Docs will be updated in separate PR once this is merged
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests