Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable rescue #3508

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove unreachable rescue #3508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/controllers/v3/service_credential_bindings_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,6 @@ def parameters
raise CloudController::Errors::ApiError.
new_from_details('ServiceFetchBindingParametersNotSupported').
with_response_code(502)
rescue LockCheck::ServiceBindingLockedError => e
raise CloudController::Errors::ApiError.new_from_details('AsyncServiceBindingOperationInProgress', e.service_binding.app.name, e.service_binding.service_instance.name)
end

private
Expand Down
2 changes: 0 additions & 2 deletions app/controllers/v3/service_route_bindings_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ def parameters
rescue ServiceBindingRead::NotSupportedError
bad_request!('user provided service instances do not support fetching route bindings parameters.') if @route_binding.service_instance.user_provided_instance?
bad_request!('this service does not support fetching route bindings parameters.')
rescue LockCheck::ServiceBindingLockedError
unprocessable!('There is an operation in progress for the service route binding.')
end

private
Expand Down