Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the annotation migration for mysql #3591

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix the annotation migration for mysql #3591

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44bf264
Fix the annotation migration for mysql
FloThinksPi Jan 9, 2024
2df3080
Disable rubocop for migration error logging
sethboyles Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions db/migrations/20240102150000_add_annotation_label_uniqueness.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def with_dropped_view(table)
label_tables = table_base_names.map { |tbn| "#{tbn}_labels" }.freeze

no_transaction # Disable automatic transactions
db_supports_table_locks = true

up do
(annotation_tables + label_tables).each do |table|
Expand All @@ -60,7 +61,13 @@ def with_dropped_view(table)

# Just allow selects on this table while the migration runs for full consistency
run "LOCK TABLE #{table}, #{table}_temp IN SHARE MODE;" if database_type == :postgres
run "LOCK TABLES #{table} WRITE, #{table}_temp WRITE;" if database_type == :mysql
begin
run "LOCK TABLES #{table} WRITE, #{table}_temp WRITE;" if database_type == :mysql && db_supports_table_locks
rescue Sequel::DatabaseError
db_supports_table_locks = false
p("Cannot guarantee consistent migration for table #{table} as your used user lacks the \"LOCK TABLE\" Permission or the database does not support locking tables (e.g. percona xtradb cluster).")
p("Continuing to do the migration for table #{table}, there is a small chance of a migration failure due to lack of above feature but eventually reruns of this migration should succeed.")
end

# Updating the temporary column with truncated keys(should never chop of anything since the api just allows 63 chars)
# We run this in the DB as to minimize the time we hold the share mode lock on the table
Expand Down Expand Up @@ -97,7 +104,7 @@ def with_dropped_view(table)
end
ensure
# Be sure to unlock the table on errors as this does not happen automatically by rolling back a transaction mysql
run 'UNLOCK TABLES;' if database_type == :mysql
run 'UNLOCK TABLES;' if database_type == :mysql && db_supports_table_locks
end
end
end
Expand Down
Loading