Prevent deletion of current droplet #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2024
philippthun
force-pushed
the
prevent-deletion-of-current-droplet
branch
4 times, most recently
from
0cd64e4 to
bfe6010
Compare
DropletsController: check if droplet is in use (i.e. app's current droplet) and raise an ApiError (UnprocessableEntity) Prepare for the introduction of a foreign key from apps.droplet_guid to droplets.guid: - DropletModel: handle ForeignKeyConstraintViolation and translate into ApiError (UnprocessableEntity) - AppModel: handle ForeignKeyConstraintViolation and translate into ValidationFailed error - DropletDelete: move destroy before other operations (deletion from blobstore, recording of event) so that an exception stops the control flow - AppDelete: clear droplet_guid (i.e. current droplet relation) before deleting subresources (incl. droplets) - AppAssignDroplet: handle ValidationFailed error and translate into already existing error - Adapt tests to also work with a foreign key
philippthun
force-pushed
the
prevent-deletion-of-current-droplet
branch
from
bfe6010 to
50bb5d6
Compare
5 tasks
jochenehret
approved these changes
Sep 18, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Sep 23, 2024
Changes in cloud_controller_ng:
- Prevent deletion of current droplet
PR: cloudfoundry/cloud_controller_ng#3960
Author: Philipp Thun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DropletsController: check if droplet is in use (i.e. app's current droplet) and raise anApiError(UnprocessableEntity)Prepare for the introduction of a foreign key from
apps.droplet_guidtodroplets.guid:DropletModel: handleForeignKeyConstraintViolationand translate intoApiError(UnprocessableEntity)AppModel: handleForeignKeyConstraintViolationand translate intoValidationFailederrorDropletDelete: move destroy before other operations (deletion from blobstore, recording of event) so that an exception stops the control flowAppDelete: cleardroplet_guid(i.e. current droplet relation) before deleting subresources (incl. droplets)AppAssignDroplet: handleValidationFailederror and translate into already existing errorI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests