Add db connection metrics #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svkrieger
force-pushed
the
add-db-connection-metrics
branch
from
57cb811 to
a75a4b6
Compare
Samze
reviewed
Sep 13, 2024
lib/cloud_controller/db.rb
Outdated
| @@ -42,6 +42,7 @@ def self.connect(opts, logger) | |||
| add_connection_expiration_extension(db, opts) | |||
| add_connection_validator_extension(db, opts) | |||
| db.extension(:requires_unique_column_names_in_subquery) | |||
| connection_metrics_extension(db) | |||
There was a problem hiding this comment.
praise Thanks for doing this! Will be great to have db metrics
philippthun
reviewed
Sep 16, 2024
svkrieger
force-pushed
the
add-db-connection-metrics
branch
from
8077200 to
3a64cb5
Compare
svkrieger
force-pushed
the
add-db-connection-metrics
branch
from
3a64cb5 to
87b3ede
Compare
philippthun
reviewed
Sep 18, 2024
svkrieger
force-pushed
the
add-db-connection-metrics
branch
from
87b3ede to
b93a519
Compare
philippthun
approved these changes
Sep 19, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Sep 19, 2024
Changes in cloud_controller_ng:
- Add DB connection metrics
PR: cloudfoundry/cloud_controller_ng#3961
Author: Sven Krieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add metrics about DB connection usage.
An explanation of the use cases your change solves
To better understand the DB connection usage, especially when using Puma, we introduce metrics which track how many connections have been opened, are currently used, available and the hold and wait duration.
Links to any other associated PRs
None
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests