Remove unused em-http-request

[sethboyles]

• this gem is blocking us from upgrading to Ruby 3.3, but it seems we don't actually use it

#3559

• I have reviewed the contributing guide

• I have viewed, signed, and submitted the Contributor License Agreement

• I have made this pull request to the main branch

• I have run all the unit tests using bundle exec rake

• I have run CF Acceptance Tests

[Samze]

question/non-blocking I see SynchronousHttpRequest is used https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/models/services/managed_service_instance.rb#L99 but is requester method called elsewhere? Quick grep would suggest maybe not.

rg requester
src/code.cloudfoundry.org/cc-uploader/handlers/upload_build_artifacts/upload_build_artifacts_test.go
131:		Context("when the requester (client) goes away", func() {

src/code.cloudfoundry.org/cc-uploader/handlers/upload_droplet/upload_droplet_test.go
178:		Context("when the requester (client) goes away", func() {

src/cloud_controller_ng/app/models/services/managed_service_instance.rb
98:    def requester

src/github.com/cloudfoundry/blobstore_url_signer/server/handler_test.go
49:			It("writes the signed URL back to requester", func() {
74:			It("writes the signed URL back to requester", func() {

Also, it seems like all of the lib/vcap/services/api stuff is from the very old v1 service broker contract, is that even used anywhere?

[sethboyles]

I didn't think about it too hard at the time because with this PR I was trying to unblock the Ruby 3.3 upgrade, but I think you're right. I made another PR that removes the other old services code to keep the priority/purpose of this PR distinct: #4085