Rework docs about NATS certificates rotation #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalermo
requested review from
a team,
klakin-pivotal,
nouseforaname and
ystros
and removed request for
a team
ystros
approved these changes
Nov 17, 2023
jpalermo
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
In the context of cloudfoundry/bosh#2473, I’ve reviewed the documentation about NATS certificates rotation, and made some improvements that I’m submitting here.
Please note that I’ve carefully separated the steps of my changes in different commits, so that the evolution can be understood more easily, if necessary.
Let me know what you think about this and if that’s ok, don’t hesitate to merge.
Cheers