Updates github-config #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the tests do not run on cflinuxfs3 with a recent version of go - this is due to the following reasons: * we bumped to the most recent version of go (1.22) * go 1.20 and higher dropped support for older versions of glibc when dynamically linking * we dynamically link the buildpackapplifecycle (v2 lifecycle) as part of the switchblade setup * therefore the BAL no longer runs on cflinuxfs3 - Alternatively, we could statically link the BAL when we build it in switchblade. But that is more work, and it is fine to only test against one stack in these tests, and there is not reason we should pick cflinuxfs3 over cflinuxfs4
robdimsdale
approved these changes
Jul 16, 2024
robdimsdale
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.