Add go-proxyproto 100ms timeout for Proxy Protocol Header #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#116601821] Signed-off-by: Shash Reddy <[email protected]>
Configure go-proxyprotocol library to wait up to 100ms for a Proxy Protocol header, before considering the incomming connection as normal. This requires a patched go-proxyproto library [1] and fixes #141 [2] [1] armon/go-proxyproto#4 [2] #141
|
Hey keymon! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/126578835 The labels on this github issue will be updated when the story is started. |
keymon
changed the title
|
/cc @crhino |
|
Build is failing because the dependencies must be updated in https://github.com/cloudfoundry-incubator/routing-release. |
|
We've merged in the PR as part of this commit: 45c41d9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As described in #141, currently the Proxy Protocol implementation has a bug that might cause go router stop accepting connections when using Proxy Protocol and a client connects without sending data.
Solutions are upgrade to Golang 1.6 used a patched version of upstream go-proxyproto which allows define a timeout to receive the Proxy Header.
This PR configure a 100ms timeout to receive the Proxy Header Protocol.
Consequences
This PR:
Dependencies and additional work
IMPORTANT:
This code depends on armon/go-proxyproto@3daa90a and it is not compatible with previous versions of the library
Once this PR is merged, https://github.com/cloudfoundry-incubator/routing-release must be updated with the submodule references for github.com/cloudfoundry/gorouter and https://github.com/armon/go-proxyproto
I will not do a PR on routing-release as it needs to be updated by whoever merges this.
How to test
We included the test added by @shashwathi to check that multiple connections can be established.
Thx
(our project story https://www.pivotaltracker.com/story/show/126483997)