Update Router to serve HTTP/2 traffic #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
6 tasks
ameowlia
requested changes
May 27, 2021
|
@ameowlia is this good to go? |
- Add integration test. - We were not able to get a router/router test working because making HTTP/2 requests to the test Server resulted in broken pipes. We believe this is due to differences in the test Server setup and the main.go setup used in the integration tests. This will require additional investigation. - Add router/router test to confirm that Gorouter can still server HTTP/1.1 traffic - Update protocol checking middleware to accept HTTP/2 [#177586561] [cloudfoundry/routing-release#200] Co-authored-by: Weyman Fung <[email protected]> Co-authored-by: Greg Cobb <[email protected]> Co-authored-by: Weyman Fung <[email protected]>
- added enableHTTP2 to config - defaults to false - passes to protocolcheck handler [cloudfoundry/routing-release#200] Co-authored-by: Weyman Fung <[email protected]>
- added an integration test for http/1.1 - removed the alpn settings if h2 is disabled Co-authored-by: Merric de Launey <[email protected]>
[cloudfoundry/routing-release#200] Co-authored-by: Greg Cobb <[email protected]> Co-authored-by: Carson Long <[email protected]>
|
@ameowlia is this PR good to go? |
|
Apologizes for the delay. Github comments are not the best way to ping me 😅 Acceptance Steps
🎉 ✨ Merging now. Thanks for all your hard work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a manifest property,
enable_http2, to enable the Gorouter to accept HTTP/2 connections. The property changes the protocol checking middleware and theserveHTTPSfunction to allow HTTP/2. Note that connections made using HTTP/2 will still be proxied to backends over HTTP/1.1 because Envoy isn't currently configured to accept HTTP/2.We added integration tests to check HTTP/2 (and updated the old ones to check that gorouter can still serve HTTP/1.1). However, we weren't able to get a router/router test working because making HTTP/2 requests to the test Server resulted in broken pipes. We believe this is due to differences in the test Server setup and the
main.gosetup used in the integration tests. This will require additional investigation.[cloudfoundry/routing-release#200]