Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GetServiceBinding to the broker client #3787

Conversation

ddraganovv
Copy link
Contributor

Is there a related GitHub Issue?

Issue

What is this change about?

This is 1 of 2 PRs related to the above issue. With this PR there is a new method introduced to the broker client which is responsible to retrieve the service binding.

Does this PR introduce a breaking change?

No

Copy link
Member

@danail-branekov danail-branekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a small comment, looks good otherwise

controllers/controllers/services/osbapi/client.go Outdated Show resolved Hide resolved
@ddraganovv ddraganovv force-pushed the service_broker_get_service_binding branch from c182ff1 to 7c3f73d Compare February 14, 2025 07:39
Copy link
Member

@danail-branekov danail-branekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, there is a minor gap in the new method test

@ddraganovv ddraganovv force-pushed the service_broker_get_service_binding branch from 7c3f73d to 191f13d Compare February 14, 2025 15:03
@danail-branekov danail-branekov merged commit 4826d1d into cloudfoundry:main Feb 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants