Add process guid to gauge envelopes #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/actions/process_stats.go
Outdated
| type PodStatsRecord struct { | ||
| ProcessGUID string | ||
| ProcessType string | ||
| // TODO: remove, this is the "instance_id" tag from the gauge envelope |
There was a problem hiding this comment.
I guess we do not need those TODOs
api/actions/process_stats.go
Outdated
| ProcessType string | ||
| // TODO: remove, this is the "instance_id" tag from the gauge envelope | ||
| Index int | ||
| // TODO: remove, this is the instance state from the process record |
georgethebeatle
force-pushed
the
issues/3752-process-id-in-envelope
branch
from
04a3d30 to
63638e0
Compare
danail-branekov
approved these changes
Feb 11, 2025
danail-branekov
force-pushed
the
issues/3752-process-id-in-envelope
branch
from
63638e0 to
4fb9888
Compare
The log cache api will be used by the process and app handlers, so that they can fetch stats for a process with a particular guid. Therefore it makes sense to filter the envelope stream for envelopes for that process guid only. In order to do so we need to have access to the process guid that the envelope is related to. The cloud controller implementation is doing the same: https://github.com/cloudfoundry/cloud_controller_ng/blob/5b1af263bbb21793ba7d49f64c75f6ab5f5ab267/lib/cloud_controller/diego/reporters/instances_stats_reporter.rb#L144 Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
issues/3752-process-id-in-envelope
branch
from
4fb9888 to
8fd5e0b
Compare
georgethebeatle
added a commit
that referenced
this pull request
Feb 12, 2025
TODO: - Set raw auth header in AuthInfo middleware - Add test for InsertOrUpdate helper - Use the new LogCacheStatsCollector from the process handler - Rebase on top of #3788 Co-authored-by: Georgi Sabev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3755
What is this change about?
The log cache api will be used by the process and app handlers, so that they
can fetch stats for a process with a particular guid. Therefore it makes
sense to filter the envelope stream for envelopes for that process guid
only. In order to do so we need to have access to the process guid that
the envelope is related to.
The cloud controller implementation is doing the same: https://github.com/cloudfoundry/cloud_controller_ng/blob/5b1af263bbb21793ba7d49f64c75f6ab5f5ab267/lib/cloud_controller/diego/reporters/instances_stats_reporter.rb#L144