fix binding controller flake #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting up the env test, we are first starting the client cache, and then starting the manager. Therefore, tear down should stop those in the reverse order, i.e. stop the manager first, and then stop the cache. Not doing that causes weird log messages that the cache is being stoppped while the test is running, e.g. https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/22070#L67a88113:44:47
Flake: https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/22068 According to failure logs, the service binding is being reconciled multiple times before the binding gets into its ready state. This means that if we stub the broker client to return a sync response on invocation 3 only, it is quite probable that the fake's sync response is not properly processed and subsequent reconciles still see that the operation is ongoing. Therefore, this change alters stubs the broker client to return a sync response (i.e. override the default async one) when it returns a succeeded operation
danail-branekov
force-pushed
the
fix-binding-controller-flake
branch
from
1211062 to
fea6dd7
Compare
georgethebeatle
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Flake: https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/22068
According to failure logs, the service binding is being reconciled
multiple times before the binding gets into its ready state.
This means that if we stub the broker client to return a sync response
on invocation 3 only, it is quite probable that the fake's sync response
is not properly processed and subsequent reconciles still see that the
operation is ongoing.
Therefore, this change alters stubs the broker client to return a sync
response (i.e. override the default async one) when it returns a
succeeded operation
While being here, also fix the order of shutting down the the k8s client cache and manager
Tag your pair, your PM, and/or team
@georgethebeatle @uzabanov