Refactor cfprocess controller #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
previously approved these changes
Feb 13, 2025
| return nil | ||
| } | ||
|
|
||
| func getProcessInstances(cfProcess *korifiv1alpha1.CFProcess) int32 { |
| desiredAppWorkload, err = r.generateAppWorkload(actualAppWorkload, cfApp, cfProcess, cfBuild, appPorts, envVars) | ||
| if err != nil { | ||
| log.Info("error when initializing AppWorkload", "reason", err) | ||
| if err = r.modifyAppWorkload(appWorkload, cfApp, cfProcess, cfBuild, appPorts, envVars); err != nil { |
There was a problem hiding this comment.
modifyAppWorkload function name sounds a bit weird to me. What this function does is that it applies desired state onto the app workload, which is what reconciliation in general is all about. How about reconcileAppWorkload? Or maybe applyToWorkload?
- Use a single app workload var instead of deep copying objects, which
is confusing
- Instead of using controllerutil.CreateOrPatch, implement a similar
behaviour ourselves
- By first trying to creaate the new appWorkload, we avoid a potential
race
- We know that we are going to need fine control over what fields are
being mutated on create vs update
- Also add a new TryPatchResource utility that can handle an error
returned by the modify func
Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
issues/refactor-process-controller
branch
from
7f13f31 to
b762607
Compare
danail-branekov
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1949
What is this change about?
Use a single app workload var instead of deep copying objects, which
is confusing
Instead of using controllerutil.CreateOrPatch, implement a similar
behaviour ourselves
race
being mutated on create vs update
Also add a new TryPatchResource utility that can handle an error
returned by the modify func