Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logout button when only the error page is shown #1289

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Add a logout button when only the error page is shown #1289

merged 1 commit into from
Oct 6, 2017

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Oct 6, 2017

Log in as a user with no endpoints registered - you get the error page but there is no logout button.

This PR fixes this.

richard-cox
richard-cox approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once through gate

@richard-cox richard-cox merged commit 7c80240 into master Oct 6, 2017
@richard-cox richard-cox deleted the no-logout-button branch October 6, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @richard-cox