Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the org spaceGuids list is updated when roles are changed #2602

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Jul 2, 2018

Bug

  • Connect as non-admin with org manager role
  • Create space and assign space dev role to connected user
  • Space missing from create/deploy app space drop down

Issue

  • When updating the connected user permissions the roles were updated.. but space was not added to the org's space list

Fixes #2592

Bug
- Connect as non-admin with org manager role
- Create space and assign space dev role to connected user
- Space missing from create/deploy app space drop down
Issue
- When updating the connected user permissions the roles were updated.. but for space was not added to the org's space list
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #2602 into v2-master will decrease coverage by 0.03%.
The diff coverage is 5%.

@@              Coverage Diff              @@
##           v2-master    #2602      +/-   ##
=============================================
- Coverage      70.02%   69.98%   -0.04%     
=============================================
  Files            595      595              
  Lines          25215    25229      +14     
  Branches        5694     5699       +5     
=============================================
  Hits           17657    17657              
- Misses          7558     7572      +14

@KlapTrap KlapTrap merged commit a3495ac into v2-master Jul 3, 2018
@KlapTrap KlapTrap deleted the fix-space-in-list branch July 3, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants