Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception thrown on home page #3420

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Fix exception thrown on home page #3420

merged 2 commits into from
Mar 8, 2019

Conversation

richard-cox
Copy link
Contributor

  • Only happens if there's a favourited entity in a non favourited endpoint and endpoint guid contains a hypen
  • Exception was.. 
    core.js:1671 ERROR TypeError: Cannot read property 'cnsi_type' of undefined
  at MapSubscriber.project (user-favorite-manager.ts:129)
  • PCFDev used with name of PCF

@richard-cox
Fix exception thrown on home page
147119b 
- Only happens if there's a favourited entity in a non favourited endpoint and endpoint guid contains a hypen
- Exception was..
  ```
  core.js:1671 ERROR TypeError: Cannot read property 'cnsi_type' of undefined
    at MapSubscriber.project (user-favorite-manager.ts:129)
  ```
@richard-cox richard-cox self-assigned this Mar 1, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #3420 into v2-master will decrease coverage by <.01%.
The diff coverage is 69.23%.

@@              Coverage Diff              @@
##           v2-master    #3420      +/-   ##
=============================================
- Coverage      70.32%   70.31%   -0.01%     
=============================================
  Files            694      694              
  Lines          30746    30760      +14     
  Branches        6995     6997       +2     
=============================================
+ Hits           21621    21629       +8     
- Misses          9125     9131       +6

@richard-cox richard-cox mentioned this pull request Mar 5, 2019
Merged
nwmac
nwmac approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit ece1bda into v2-master Mar 8, 2019
@nwmac nwmac deleted the fix-fav-hypen-cf-guid branch June 12, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac