Fix 'unknown locale' error message when viewing service plans

src/frontend/packages/core/src/shared/components/add-service-instance/select-plan-step/select-plan-step.component.ts

@@ -1,5 +1,4 @@
-import { registerLocaleData, TitleCasePipe } from '@angular/common';
-import localeFr from '@angular/common/locales/fr';
+import { TitleCasePipe } from '@angular/common';
 import {
   ChangeDetectionStrategy,
   Component,
@@ -25,27 +24,27 @@ import {
   withLatestFrom,
 } from 'rxjs/operators';
 
-import { IServicePlan } from '../../../../core/cf-api-svc.types';
-import { StepOnNextResult } from '../../stepper/step/step.component';
-import { CreateServiceInstanceHelperServiceFactory } from '../create-service-instance-helper-service-factory.service';
-import { CreateServiceInstanceHelper } from '../create-service-instance-helper.service';
-import { CsiModeService } from '../csi-mode.service';
-import { NoServicePlansComponent } from '../no-service-plans/no-service-plans.component';
-import { APIResource, EntityInfo } from '../../../../../../store/src/types/api.types';
-import { AppState } from '../../../../../../store/src/app-state';
 import {
   SetCreateServiceInstanceCFDetails,
-  SetCreateServiceInstanceServicePlan
+  SetCreateServiceInstanceServicePlan,
 } from '../../../../../../store/src/actions/create-service-instance.actions';
+import { AppState } from '../../../../../../store/src/app-state';
 import { selectCreateServiceInstance } from '../../../../../../store/src/selectors/create-service-instance.selectors';
-import { CardStatus } from '../../../shared.types';
+import { APIResource } from '../../../../../../store/src/types/api.types';
+import { IServicePlan } from '../../../../core/cf-api-svc.types';
+import { safeUnsubscribe } from '../../../../core/utils.service';
 import {
-  populateServicePlanExtraTyped,
+  canShowServicePlanCosts,
   getServicePlanAccessibilityCardStatus,
   getServicePlanName,
-  canShowServicePlanCosts
+  populateServicePlanExtraTyped,
 } from '../../../../features/service-catalog/services-helper';
-import { safeUnsubscribe } from '../../../../core/utils.service';
+import { CardStatus } from '../../../shared.types';
+import { StepOnNextResult } from '../../stepper/step/step.component';
+import { CreateServiceInstanceHelperServiceFactory } from '../create-service-instance-helper-service-factory.service';
+import { CreateServiceInstanceHelper } from '../create-service-instance-helper.service';
+import { CsiModeService } from '../csi-mode.service';
+import { NoServicePlansComponent } from '../no-service-plans/no-service-plans.component';
 
 @Component({
   selector: 'app-select-plan-step',
@@ -76,8 +75,6 @@ export class SelectPlanStepComponent implements OnDestroy {
     private modeService: CsiModeService
 
   ) {
-    registerLocaleData(localeFr);
-
     this.stepperForm = new FormGroup({
       servicePlans: new FormControl('', Validators.required),
     });

src/frontend/packages/core/src/shared/components/list/list-types/service-plans/service-plans-list-config.service.ts

@@ -24,8 +24,6 @@ import {
 
 
 /**
- * Service instance list shown for `service / service instances` component
- *
  * @export
  */
 @Injectable()

src/frontend/packages/core/src/shared/components/service-plan-price/service-plan-price.component.ts

@@ -1,7 +1,10 @@
+import { registerLocaleData } from '@angular/common';
+import localeFr from '@angular/common/locales/fr';
 import { Component, Input } from '@angular/core';
 
-import { IServicePlan, IServicePlanCost } from '../../../core/cf-api-svc.types';
 import { APIResource } from '../../../../../store/src/types/api.types';
+import { IServicePlan, IServicePlanCost } from '../../../core/cf-api-svc.types';
+
 
 @Component({
   selector: 'app-service-plan-price',
@@ -12,6 +15,10 @@ export class ServicePlanPriceComponent {
 
   @Input() servicePlan: APIResource<IServicePlan>;
 
+  constructor() {
+    registerLocaleData(localeFr);
+  }
+
   /*
  * Pick the first country listed in the amount object. It's unclear whether there could be a different number of these depending on
  * which region the CF is being served from (IBM seem to charge different amounts per country)