HSC-1292 - Resurrecting e2e concourse pipeline #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfanhabib
commented
Nov 4, 2016
| @@ -175,6 +175,9 @@ | |||
| * */ | |||
| function checkAndCloseToast(matchStringOrRegex) { | |||
|
|
|||
| // Allow time for the animated toaster to become visible | |||
| browser.driver.sleep(250); | |||
|
|
|||
There was a problem hiding this comment.
Fix from @richard-cox for the intermittently failing Execute Disconnect test
Not needed
julbra
reviewed
Nov 7, 2016
| # Due to a conflict in Gulp 3, we need to run this again | ||
| RUN npm install | ||
| RUN apt-get update && \ | ||
| apt-get install -y openjdk-7-jre-headless && \ |
julbra
reviewed
Nov 7, 2016
| cd ${TOOLS_DIR} | ||
| cp -r /node_modules . | ||
| if [ "$(md5sum /package.json | cut -d' ' -f1)" != "$(md5sum package.json| cut -d' ' -f1)" ]; then | ||
| echo -e "\033[31mpackage.json was updated, please update the image. Running npm install\033[0m" |
There was a problem hiding this comment.
Do we have the name of the image that needs updating? Maybe point to the script.
julbra
reviewed
Nov 7, 2016
| fi | ||
| PATH=$PATH:$TOOLS_DIR/node_modules/.bin | ||
| bower install --allow-root --force | ||
| npm run update-webdriver |
There was a problem hiding this comment.
Let's do the update in the pre-headless-e2e npm script like Rich did for e2e and pree2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Dockerfile.dev to use the custom image
stackatotest/hsc-concoursewhich contains preinstalled packages to save time when bringing the console up. The image is generated fromDockerfile.concourse