Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom #71

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Zoom #71

merged 2 commits into from
Nov 29, 2022

Conversation

colbyfayock
Copy link
Collaborator

Description

Adds the ability to use the zoom prop when using crop modes crop and thumb.

This additionally fixes / corrects an issue where the responsive generation would add the sizes to the image URLs, upscaling the images unnecessarily, which adds more page load unnecessarily and creates inconsistencies with overlays with different sizes. The result is that the width/height must or should be set to the image's actual width/height to allow the generation to properly resize.

Issue Ticket Number

Fixes #70

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-cloudinary ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 5:56PM (UTC)

@colbyfayock colbyfayock merged commit aace374 into main Nov 29, 2022
@colbyfayock colbyfayock deleted the feat/70-zoom branch November 29, 2022 17:57
github-actions bot pushed a commit that referenced this pull request Nov 29, 2022
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
1f3c18f 
# [1.2.0](v1.1.0...v1.2.0) (2022-11-29)

### Features

* Zoom ([#71](#71)) ([aace374](aace374)), closes [#70](#70)
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this pull request Dec 23, 2023
@cham74
chore(release): 1.2.0 [skip ci]
99da520 
# [1.2.0](cloudinary-community/next-cloudinary@v1.1.0...v1.2.0) (2022-11-29)

### Features

* Zoom ([#71](cloudinary-community/next-cloudinary#71)) ([aace374](cloudinary-community/next-cloudinary@aace374)), closes [#70](cloudinary-community/next-cloudinary#70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Zoom prop
1 participant
@colbyfayock