Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest video player #1006

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Use the latest video player #1006

merged 2 commits into from
Jan 14, 2025

Conversation

pereirinha
Copy link
Member

Update the video player

@pereirinha pereirinha marked this pull request as ready for review December 20, 2024 16:08
Copy link
Collaborator

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are styles and scripts which use this as a version string which means that it will update without changing those and it could pick up cached versions inconsistently. Should those be updated also or maybe that's a reason to hold it to a given version?

@pereirinha
Copy link
Member Author

Excellent point @tharsheblows

Copy link
Collaborator

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pereirinha pereirinha merged commit c772009 into develop Jan 14, 2025
6 checks passed
@pereirinha pereirinha deleted the feature/update-video-player branch January 14, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants