Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use_alb_security_group flag #37

Merged
merged 7 commits into from
Apr 21, 2021
Merged

Add use_alb_security_group flag #37

merged 7 commits into from
Apr 21, 2021

Conversation

maeghan-porter
Copy link
Contributor

what

  • Adding the use_alb_security_group flag to pass along to the ecs-web-app module so that a security group ingress rule will be added to the service for the ALB.

why

  • The service needs to allow access from the ALB else the connectivity from ALB to atlantis will not work. This functionality was lost for me in an upgrade from version 0.14.0 of this module to the latest version (0.22.0).

@maeghan-porter maeghan-porter requested review from a team as code owners April 21, 2021 21:37
@maeghan-porter maeghan-porter requested a review from a team as a code owner April 21, 2021 21:37
jamengual
jamengual previously approved these changes Apr 21, 2021
View reviewed changes
@jamengual
Copy link
Contributor

/test all

@mergify mergify bot dismissed jamengual’s stale review April 21, 2021 21:46

This Pull Request has been updated, so we're dismissing all reviews.

@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit 436f85f into cloudposse-archives:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maeghan-porter @jamengual @cloudpossebot