fix panic when reading from context

cloudposse · Dec 16, 2024 · 7c8ad62 · 7c8ad62
1 parent 0662bec
commit 7c8ad62
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 8 deletions.
diff --git a/cmd/cmd_utils.go b/cmd/cmd_utils.go
@@ -480,10 +480,13 @@ func customHelpMessageToUpgradeToAtmosLatestRelease(cmd *cobra.Command, args []s
 	if value == nil {
 		u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("atmos configuration not found in context"))
 	}
-	atmosConfig := value.(*schema.CliConfiguration)
+	atmosConfig, ok := value.(schema.CliConfiguration)
+	if !ok {
+		u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("invalid atmos configuration type in context"))
+	}
 
 	originalHelpFunc(cmd, args)
-	CheckForAtmosUpdateAndPrintMessage(*atmosConfig)
+	CheckForAtmosUpdateAndPrintMessage(atmosConfig)
 }
 
 // Check Atmos is version command

diff --git a/cmd/helmfile.go b/cmd/helmfile.go
@@ -40,9 +40,12 @@ var helmfileCmd = &cobra.Command{
 			if value == nil {
 				u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("atmos configuration not found in context"))
 			}
-			atmosConfig := value.(*schema.CliConfiguration)
+			atmosConfig, ok := value.(schema.CliConfiguration)
+			if !ok {
+				u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("invalid atmos configuration type in context"))
+			}
 
-			CheckForAtmosUpdateAndPrintMessage(*atmosConfig)
+			CheckForAtmosUpdateAndPrintMessage(atmosConfig)
 			return
 		}
 

diff --git a/cmd/terraform.go b/cmd/terraform.go
@@ -40,9 +40,12 @@ var terraformCmd = &cobra.Command{
 			if value == nil {
 				u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("atmos configuration not found in context"))
 			}
-			atmosConfig := value.(*schema.CliConfiguration)
+			atmosConfig, ok := value.(schema.CliConfiguration)
+			if !ok {
+				u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("invalid atmos configuration type in context"))
+			}
 
-			CheckForAtmosUpdateAndPrintMessage(*atmosConfig)
+			CheckForAtmosUpdateAndPrintMessage(atmosConfig)
 			return
 		}
 

diff --git a/cmd/version.go b/cmd/version.go
@@ -57,8 +57,11 @@ var versionCmd = &cobra.Command{
 		if value == nil {
 			u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("atmos configuration not found in context"))
 		}
-		atmosConfig := value.(*schema.CliConfiguration)
-		CheckForAtmosUpdateAndPrintMessage(*atmosConfig)
+		atmosConfig, ok := value.(schema.CliConfiguration)
+		if !ok {
+			u.LogErrorAndExit(schema.CliConfiguration{}, fmt.Errorf("invalid atmos configuration type in context"))
+		}
+		CheckForAtmosUpdateAndPrintMessage(atmosConfig)
 	},
 }