Apply suggestions from code review

Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
cloudposse · Jan 3, 2025 · b8245ca · b8245ca
1 parent 971be07
commit b8245ca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/exec/shell_utils.go b/internal/exec/shell_utils.go
@@ -193,7 +193,7 @@ func execTerraformShellCommand(
 		envVar := fmt.Sprintf("TF_CLI_ARGS_%s", cmd)
 		existing := os.Getenv(envVar)
 		if existing != "" {
-			u.LogWarning(atmosConfig, fmt.Sprintf("Found Terraform environment variable '%s' which may conflict with or be overwritten by Atmos", envVar))
+			u.LogWarning(atmosConfig, fmt.Sprintf("detected '%s' set in the environment; this may interfere with Atmos's control of Terraform.", envVar))
 			// Remove any surrounding quotes from existing value
 			existing = strings.Trim(existing, "\"")
 			// Create new value by combining existing and new var-file argument

diff --git a/internal/exec/terraform.go b/internal/exec/terraform.go
@@ -235,7 +235,7 @@ func ExecuteTerraform(info schema.ConfigAndStacksInfo) error {
 	for _, envVar := range os.Environ() {
 		if strings.HasPrefix(envVar, "TF_") {
 			varName := strings.Split(envVar, "=")[0]
-			u.LogWarning(atmosConfig, fmt.Sprintf("Found Terraform environment variable '%s' which may conflict with or be overwritten by Atmos", varName))
+			u.LogWarning(atmosConfig, fmt.Sprintf("detected '%s' set in the environment; this may interfere with Atmos's control of Terraform.", varName))
 		}
 	}